Skip to content

Conversation

@matthieuuu
Copy link
Contributor

cf #11

@matthieuuu matthieuuu mentioned this pull request Feb 4, 2026
jbelien
jbelien previously approved these changes Feb 5, 2026
@jbelien jbelien dismissed their stale review February 5, 2026 19:25

A bit too soon ...

@jbelien
Copy link
Member

jbelien commented Feb 5, 2026

Thanks, could you also fix the tests?
Apparently, there are some changes in the results.

@matthieuuu
Copy link
Contributor Author

Seems good now. Thanks!

@jbelien
Copy link
Member

jbelien commented Feb 6, 2026

Tests seem to still be failing, could you have a look ?

Also, why replacing Meaux by Grenoble ?

@matthieuuu
Copy link
Contributor Author

Meaux was interpreted as a street first, not a city.
I don't understand what's wrong with the last test (it was working this morning), gonna fix it

update test testGeocodeLocalityQuery
@matthieuuu
Copy link
Contributor Author

Seems good now. Thanks!

@jbelien jbelien merged commit cd79713 into geo6:master Feb 7, 2026
10 of 12 checks passed
@jbelien jbelien linked an issue Feb 7, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API URL migration

2 participants